public inbox for goredo-devel@lists.stargrave.org Atom feed
* REDO_JS_FD has extra whitespace @ 2021-09-30 1:39 Andrew Chambers 2021-09-30 10:01 ` Sergey Matveev 0 siblings, 1 reply; 2+ messages in thread From: Andrew Chambers @ 2021-09-30 1:39 UTC (permalink / raw) To: goredo-devel I was working on a package tree[1] that uses goredo job server feature and noticed the REDO_JS_FD env var contains extra spaces: i.e REDO_JS_FD=" 6,7", this seems like a mistake, so just letting you know. [1] https://github.com/andrewchambers/coolports ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: REDO_JS_FD has extra whitespace 2021-09-30 1:39 REDO_JS_FD has extra whitespace Andrew Chambers @ 2021-09-30 10:01 ` Sergey Matveev 0 siblings, 0 replies; 2+ messages in thread From: Sergey Matveev @ 2021-09-30 10:01 UTC (permalink / raw) To: goredo-devel [-- Attachment #1: Type: text/plain, Size: 525 bytes --] Greetings! *** Andrew Chambers [2021-09-30 14:39]: >noticed the REDO_JS_FD env var contains extra spaces That is not mistake, just "%s %s%d,%d" format string, with all %s-es empty. Just single simple code for all jobservers compatibility (goredo can work with GNU Make and bmake jobservers too, where REDO_JS_FD will differ). However I agree that it is not pleasant to look at, but code is simple :-) -- Sergey Matveev (http://www.stargrave.org/) OpenPGP: CF60 E89A 5923 1E76 E263 6422 AE1A 8109 E498 57EF [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-30 10:11 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-09-30 1:39 REDO_JS_FD has extra whitespace Andrew Chambers 2021-09-30 10:01 ` Sergey Matveev