Bugette: The hjson-cli command has an empty version string

public inbox for nncp-devel@lists.stargrave.org
Atom feed

* Bugette: The hjson-cli command has an empty version string
@ 2025-09-20  7:53 Klaus Alexander Seiﬆrup
  2025-09-20 12:25 ` Sergey Matveev
  0 siblings, 1 reply; 3+ messages in thread
From: Klaus Alexander Seiﬆrup @ 2025-09-20  7:53 UTC (permalink / raw)
  To: NNCP Development

Hey,

I am the packager of the nncp package on AUR, and I noticed that the bin/hjson-cli command is unaware of its own version.

As per https://github.com/hjson/hjson-go/blob/master/build_release.sh the version should be set during build with

  -X main.Version=${VERSION}

It is impossible to derive $VERSION from the contents of the hjson-cli command included in the vendor directory.

Cheers,

-- 
Kʟᴀᴜꜱ Aʟᴇxᴀɴᴅᴇʀ Sᴇɪꜱᴛʀᴜᴘ 🇩🇰

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Bugette: The hjson-cli command has an empty version string
  2025-09-20  7:53 Bugette: The hjson-cli command has an empty version string Klaus Alexander Seiﬆrup
@ 2025-09-20 12:25 ` Sergey Matveev
  2025-09-20 13:18   ` Klaus Alexander Seiﬆrup
  0 siblings, 1 reply; 3+ messages in thread
From: Sergey Matveev @ 2025-09-20 12:25 UTC (permalink / raw)
  To: nncp-devel

[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

Greetings!

*** Klaus Alexander Seiﬆrup [2025-09-20 09:53]:
>bin/hjson-cli command is unaware of its own version.
>It is impossible to derive $VERSION from the contents of the hjson-cli command included in the vendor directory.

Yep, you are right. Thanks for pointing that out!
Fixed in 8.12.1 release.

-- 
Sergey Matveev (http://www.stargrave.org/)
LibrePGP: 12AD 3268 9C66 0D42 6967  FD75 CB82 0563 2107 AD8A

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 265 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Bugette: The hjson-cli command has an empty version string
  2025-09-20 12:25 ` Sergey Matveev
@ 2025-09-20 13:18   ` Klaus Alexander Seiﬆrup
  0 siblings, 0 replies; 3+ messages in thread
From: Klaus Alexander Seiﬆrup @ 2025-09-20 13:18 UTC (permalink / raw)
  To: nncp-devel

Hey!

Sergey Matveev wrote:

> Fixed in 8.12.1 release.

Splendid, thanks! :)

-- 
Kʟᴀᴜꜱ Aʟᴇxᴀɴᴅᴇʀ Sᴇɪꜱᴛʀᴜᴘ 🇩🇰

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-09-20 13:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-20  7:53 Bugette: The hjson-cli command has an empty version string Klaus Alexander Seiﬆrup
2025-09-20 12:25 ` Sergey Matveev
2025-09-20 13:18   ` Klaus Alexander Seiﬆrup