public inbox for nncp-devel@lists.stargrave.org
Atom feed
* [nncp-devel] EOF while decoding 8 bytes / message authentication failed
@ 2019-12-13 9:19 Frank Doepper
2019-12-13 16:20 ` Sergey Matveev
0 siblings, 1 reply; 15+ messages in thread
From: Frank Doepper @ 2019-12-13 9:19 UTC (permalink / raw)
To: nncp-devel
Hi,
I have built nncp on NixOS with this expression:
{ stdenv, go, fetchurl }:
stdenv.mkDerivation rec {
pname = "nncp";
version = "5.1.1";
buildInputs = [ go ];
preConfigure = ''
export GOCACHE=$PWD/.cache
'';
makeFlags = [ "PREFIX=$$out" ];
src = fetchurl {
url = "http://www.nncpgo.org/download/${pname}-${version}.tar.xz";
sha256 = "0gx9c9v5xnc8ldisz7xb5hgx6km9sjr423fjl1pvljdmwmw7clxr";
};
}
When I then use nncp-call with nncp-daemon, I get connection error:
client side:
$ nncp-call --debug self
D 2019-12-13T09:10:45.315581037Z [call addr="zachiel.fritz.box:5400" node="AKKXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXA"] dialing
D 2019-12-13T09:10:45.322352661Z [call addr="zachiel.fritz.box:5400" node="AKKXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXA"] connected
D 2019-12-13T09:10:45.425437863Z [jobs name="ZNNXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXA" nice="224" node="AKKXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXA" size="3489441" xx="tx"] taken
D 2019-12-13T09:10:45.48071147Z [jobs name="7IAXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXQ" nice="224" node="AKKXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXA" size="3489441" xx="tx"] taken
D 2019-12-13T09:10:45.480861796Z [sp-info-our name="ZNNXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXA" node="AKKXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXA" size="3489441"]
D 2019-12-13T09:10:45.480886096Z [sp-info-our name="7IAXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXQ" node="AKKXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXA" size="3489441"]
2019-12-13T09:10:45Z We have got for self: 2 packets, 6.7 MiB
D 2019-12-13T09:10:45.499071069Z [sp-start nice="255" node="AKKXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXA"] sending first message
D 2019-12-13T09:10:45.499320081Z [sp-start nice="255" node="AKKXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXA"] waiting for first message
E 2019-12-13T09:10:45.500430758Z [sp-start err="xdr:DecodeFixedOpaque: EOF while decoding 8 bytes - read: '[]'" nice="255" node="AKKXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXA"]
2019-12-13T09:10:45Z ERROR Connected to self
daemon side:
$ nncp-daemon -debug
D 2019-12-13T09:10:45.322423859Z [daemon addr="192.168.178.21:39060"] accepted
D 2019-12-13T09:10:45.322866333Z [sp-start nice="255"] waiting for first message
E 2019-12-13T09:10:45.499635152Z [sp-start err="chacha20poly1305: message authentication failed"]
2019-12-13T09:10:45Z ERROR Connected to unknown
^C
How to debug this? Same error when connecting to another machine.
But exchanging via nncp-file works.
спасибо большое
Frank
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [nncp-devel] EOF while decoding 8 bytes / message authentication failed
2019-12-13 9:19 [nncp-devel] EOF while decoding 8 bytes / message authentication failed Frank Doepper
@ 2019-12-13 16:20 ` Sergey Matveev
2019-12-17 15:26 ` Frank Doepper
0 siblings, 1 reply; 15+ messages in thread
From: Sergey Matveev @ 2019-12-13 16:20 UTC (permalink / raw)
To: nncp-devel
[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]
Greetings!
*** Frank Doepper [2019-12-13 10:19]:
>E 2019-12-13T09:10:45.499635152Z [sp-start err="chacha20poly1305: message authentication failed"]
That error means that your symmetric key, derived during Noise protocol
handshake, is differs and thus peers are not mutually authenticated. As
Shawn K. Quinn mentioned and I debugged, I mistakenly swapped private
and public keys in newly created configuration files, making them
unworkable with online protocol (Noise is used only there).
I have fixed it in the new 5.1.2 release. Also I accidentally found very
serious and critical remote peer authentication bug too. It is very
advisable to update NNCP. Sorry for that mistakes and lack of tests
(shameful lack of time), that will find both of those serious bugs.
>E 2019-12-13T09:10:45.500430758Z [sp-start err="xdr:DecodeFixedOpaque: EOF while decoding 8 bytes - read: '[]'" nice="255" node="AKKXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXA"]
>2019-12-13T09:10:45Z ERROR Connected to self
I have also fixed that ugly and fearfull message, making it more nicer
and telling that ordinary EOF occurred (link is broken, disconnected, etc).
--
Sergey Matveev (http://www.stargrave.org/)
OpenPGP: CF60 E89A 5923 1E76 E263 6422 AE1A 8109 E498 57EF
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [nncp-devel] EOF while decoding 8 bytes / message authentication failed
2019-12-13 16:20 ` Sergey Matveev
@ 2019-12-17 15:26 ` Frank Doepper
2019-12-20 9:01 ` Sergey Matveev
0 siblings, 1 reply; 15+ messages in thread
From: Frank Doepper @ 2019-12-17 15:26 UTC (permalink / raw)
To: Sergey Matveev; +Cc: nncp-devel
Am 13.12.19 um 19:20 schrieb Sergey Matveev:
> I have fixed it in the new 5.1.2 release.
Thanks for your quick response and fix! Now it works fine.
I have made a PR to include NNCP in NixOS.
https://github.com/NixOS/nixpkgs/pull/75772
And, next bug report, it seems to me that the -onlinedeadline option is
completely ignored, both on the nncp-call cmdline as in the call or caller
config.
Best regards,
Frank
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [nncp-devel] EOF while decoding 8 bytes / message authentication failed
2019-12-17 15:26 ` Frank Doepper
@ 2019-12-20 9:01 ` Sergey Matveev
2019-12-20 11:32 ` Frank Doepper
0 siblings, 1 reply; 15+ messages in thread
From: Sergey Matveev @ 2019-12-20 9:01 UTC (permalink / raw)
To: nncp-devel
[-- Attachment #1: Type: text/plain, Size: 1809 bytes --]
Greetings!
*** Frank Doepper [2019-12-17 16:26]:
>And, next bug report, it seems to me that the -onlinedeadline option is
>completely ignored, both on the nncp-call cmdline as in the call or caller
>config.
Well, either bug is somewhere really exists, or there is some
misunderstanding of onlinedeadline option. It is just a time when no SP
packets received and we will close connection. onlinedeadline 60 means
that if no packets from both directions are not passed during the
minute, then we will close connection.
Each node could have its own onlinedeadline value, independent from
remote side. So if our local node is told to use 60 seconds, but remote
one uses default 10 seconds, then that remote node will close connection
anyway after that 10 seconds (if no SP packets are passed during that
time).
For example my remote node (gw.stargrave.org) is configured to use 3600
seconds and I call it locally:
% date ; nncp-call -onlinedeadline 10 gw.stargrave.org:main ; date
Fr. 20 Dez. 2019 11:47:15 MSK
2019-12-20T08:47:15Z Connection to gw.stargrave.org
2019-12-20T08:47:25Z Finished call with gw.stargrave.org: 32 KiB received (32 KiB/sec), 32 KiB transferred (32 KiB/sec)
Fr. 20 Dez. 2019 11:47:25 MSK
% date ; nncp-call -onlinedeadline 60 gw.stargrave.org:main ; date
Fr. 20 Dez. 2019 11:47:31 MSK
2019-12-20T08:47:31Z Connection to gw.stargrave.org
2019-12-20T08:48:31Z Finished call with gw.stargrave.org: 32 KiB received (32 KiB/sec), 32 KiB transferred (32 KiB/sec)
Fr. 20 Dez. 2019 11:48:31 MSK
So it works as expected. I also checked that configuration file's call
settings onlinedeadline works too.
--
Sergey Matveev (http://www.stargrave.org/)
OpenPGP: CF60 E89A 5923 1E76 E263 6422 AE1A 8109 E498 57EF
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [nncp-devel] EOF while decoding 8 bytes / message authentication failed
2019-12-20 9:01 ` Sergey Matveev
@ 2019-12-20 11:32 ` Frank Doepper
2019-12-20 13:51 ` Sergey Matveev
0 siblings, 1 reply; 15+ messages in thread
From: Frank Doepper @ 2019-12-20 11:32 UTC (permalink / raw)
To: Sergey Matveev; +Cc: nncp-devel
Am 20.12.19 um 12:01 schrieb Sergey Matveev:
> Each node could have its own onlinedeadline value, independent from
> remote side. So if our local node is told to use 60 seconds, but remote
> one uses default 10 seconds, then that remote node will close connection
> anyway after that 10 seconds (if no SP packets are passed during that
> time).
>
> For example my remote node (gw.stargrave.org) is configured to use 3600
> seconds and I call it locally:
>
> % date ; nncp-call -onlinedeadline 10 gw.stargrave.org:main ; date
> Fr. 20 Dez. 2019 11:47:15 MSK
> 2019-12-20T08:47:15Z Connection to gw.stargrave.org
> 2019-12-20T08:47:25Z Finished call with gw.stargrave.org: 32 KiB received (32 KiB/sec), 32 KiB transferred (32 KiB/sec)
> Fr. 20 Dez. 2019 11:47:25 MSK
>
> % date ; nncp-call -onlinedeadline 60 gw.stargrave.org:main ; date
> Fr. 20 Dez. 2019 11:47:31 MSK
> 2019-12-20T08:47:31Z Connection to gw.stargrave.org
> 2019-12-20T08:48:31Z Finished call with gw.stargrave.org: 32 KiB received (32 KiB/sec), 32 KiB transferred (32 KiB/sec)
> Fr. 20 Dez. 2019 11:48:31 MSK
>
> So it works as expected. I also checked that configuration file's call
> settings onlinedeadline works too.
Thanks for clarification, I missed that this is an option at both ends.
If the connection should end after the smaller of both ends' value, I
wonder why "nncp-call -onlinedeadline 2 otherhost" still lasts exactly 10
seconds in my case (empty queue on both sides, no onlinedeadline config
line in config file).
How to set -onlinedeadline for nncp-daemon?
NNCP version 5.2.1 built with go1.12.9
Big thanks and best regards,
Frank
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [nncp-devel] EOF while decoding 8 bytes / message authentication failed
2019-12-20 11:32 ` Frank Doepper
@ 2019-12-20 13:51 ` Sergey Matveev
2019-12-20 14:04 ` Frank Doepper
0 siblings, 1 reply; 15+ messages in thread
From: Sergey Matveev @ 2019-12-20 13:51 UTC (permalink / raw)
To: nncp-devel
[-- Attachment #1: Type: text/plain, Size: 865 bytes --]
*** Frank Doepper [2019-12-20 12:32]:
>If the connection should end after the smaller of both ends' value, I
>wonder why "nncp-call -onlinedeadline 2 otherhost" still lasts exactly 10
>seconds in my case (empty queue on both sides, no onlinedeadline config
>line in config file).
Oh, this is another code's peculiarity. Reading/writing is done with:
conn.SetReadDeadline(time.Now().Add(DefaultDeadline * time.Second)),
where DefaultDeadline is 10 (seconds). So goroutine "ticks" every 10sec
by default and that is why lower onlinedeadline values are not checked
earlier. I will look how to easily change the logic of that.
>How to set -onlinedeadline for nncp-daemon?
Only through per-node onlinedeadline option in configuration file.
--
Sergey Matveev (http://www.stargrave.org/)
OpenPGP: CF60 E89A 5923 1E76 E263 6422 AE1A 8109 E498 57EF
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [nncp-devel] EOF while decoding 8 bytes / message authentication failed
2019-12-20 13:51 ` Sergey Matveev
@ 2019-12-20 14:04 ` Frank Doepper
2019-12-22 18:30 ` Sergey Matveev
0 siblings, 1 reply; 15+ messages in thread
From: Frank Doepper @ 2019-12-20 14:04 UTC (permalink / raw)
To: Sergey Matveev; +Cc: nncp-devel
Am 20.12.19 um 16:51 schrieb Sergey Matveev:
> *** Frank Doepper [2019-12-20 12:32]:
> >If the connection should end after the smaller of both ends' value, I
> >wonder why "nncp-call -onlinedeadline 2 otherhost" still lasts exactly 10
> >seconds in my case (empty queue on both sides, no onlinedeadline config
> >line in config file).
>
> Oh, this is another code's peculiarity. Reading/writing is done with:
> conn.SetReadDeadline(time.Now().Add(DefaultDeadline * time.Second)),
> where DefaultDeadline is 10 (seconds). So goroutine "ticks" every 10sec
> by default and that is why lower onlinedeadline values are not checked
> earlier. I will look how to easily change the logic of that.
This is fully ok. Just needs to be documented. (Or have I overlooked it?)
:)
> >How to set -onlinedeadline for nncp-daemon?
>
> Only through per-node onlinedeadline option in configuration file.
Fine. I'll test again.
Best regards,
Frank
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [nncp-devel] EOF while decoding 8 bytes / message authentication failed
2019-12-20 14:04 ` Frank Doepper
@ 2019-12-22 18:30 ` Sergey Matveev
2019-12-22 20:17 ` Shawn K. Quinn
0 siblings, 1 reply; 15+ messages in thread
From: Sergey Matveev @ 2019-12-22 18:30 UTC (permalink / raw)
To: nncp-devel
[-- Attachment #1: Type: text/plain, Size: 490 bytes --]
*** Frank Doepper [2019-12-20 15:04]:
>> Oh, this is another code's peculiarity. Reading/writing is done with:
>> conn.SetReadDeadline(time.Now().Add(DefaultDeadline * time.Second)),
>> I will look how to easily change the logic of that.
>
>This is fully ok. Just needs to be documented. (Or have I overlooked it?)
5.3.0 release checks onlinedeadline every second now.
--
Sergey Matveev (http://www.stargrave.org/)
OpenPGP: CF60 E89A 5923 1E76 E263 6422 AE1A 8109 E498 57EF
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [nncp-devel] EOF while decoding 8 bytes / message authentication failed
2019-12-22 18:30 ` Sergey Matveev
@ 2019-12-22 20:17 ` Shawn K. Quinn
2019-12-22 20:42 ` Sergey Matveev
` (2 more replies)
0 siblings, 3 replies; 15+ messages in thread
From: Shawn K. Quinn @ 2019-12-22 20:17 UTC (permalink / raw)
To: nncp-devel
On 12/22/19 12:30, Sergey Matveev wrote:
> 5.3.0 release checks onlinedeadline every second now.
And now connections fail 10 seconds in every time:
E 2019-12-22T20:13:22.332512348Z [sp-xmit err="write tcp
[fe80::...:5e67%w...] 58276->[fe80::...:ff35%w...]:5400: use of closed
network connection" nice="255" node="WX..QA"]
Do we really need to be able to specify a connection remains open for
only 1 or 2 seconds, or any value less than 10?
--
Shawn K. Quinn <skquinn@rushpost•com>
http://www.rantroulette.com
http://www.skqrecordquest.com
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [nncp-devel] EOF while decoding 8 bytes / message authentication failed
2019-12-22 20:17 ` Shawn K. Quinn
@ 2019-12-22 20:42 ` Sergey Matveev
2019-12-24 11:59 ` Frank Doepper
2019-12-25 13:41 ` Sergey Matveev
2 siblings, 0 replies; 15+ messages in thread
From: Sergey Matveev @ 2019-12-22 20:42 UTC (permalink / raw)
To: nncp-devel
[-- Attachment #1: Type: text/plain, Size: 770 bytes --]
*** Shawn K. Quinn [2019-12-22 14:17]:
>And now connections fail 10 seconds in every time:
Hm, that is strange. Currently I can not locally reproduce the problem.
My nncp-call/caller/daemon finish the call without any errors
with/without specifying onlinedeadline option both in command line and
configuration file. Will try to reproduce later.
>Do we really need to be able to specify a connection remains open for
>only 1 or 2 seconds, or any value less than 10?
Actually I think not, but the change allowing that behaviour gives more
beauty code. There was no aim to be able to quit after several seconds,
just code logic simplification.
--
Sergey Matveev (http://www.stargrave.org/)
OpenPGP: CF60 E89A 5923 1E76 E263 6422 AE1A 8109 E498 57EF
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [nncp-devel] EOF while decoding 8 bytes / message authentication failed
2019-12-22 20:17 ` Shawn K. Quinn
2019-12-22 20:42 ` Sergey Matveev
@ 2019-12-24 11:59 ` Frank Doepper
2019-12-25 13:41 ` Sergey Matveev
2 siblings, 0 replies; 15+ messages in thread
From: Frank Doepper @ 2019-12-24 11:59 UTC (permalink / raw)
To: nncp-devel
Am 22.12.19 um 14:17 schrieb Shawn K. Quinn:
> On 12/22/19 12:30, Sergey Matveev wrote:
> > 5.3.0 release checks onlinedeadline every second now.
>
> And now connections fail 10 seconds in every time:
>
> E 2019-12-22T20:13:22.332512348Z [sp-xmit err="write tcp
> [fe80::...:5e67%w...] 58276->[fe80::...:ff35%w...]:5400: use of closed
> network connection" nice="255" node="WX..QA"]
Same here, I get "use of closed network connection" or "write: broken
pipe" or "write: connection reset by peer" after >10 <11 seconds.
caller is
NNCP version 5.3.0 built with go1.12.9 on i686,
daemon is
NNCP version 5.3.0 built with go1.13.3 in Termux on Android.
best regards,
Frank
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [nncp-devel] EOF while decoding 8 bytes / message authentication failed
2019-12-22 20:17 ` Shawn K. Quinn
2019-12-22 20:42 ` Sergey Matveev
2019-12-24 11:59 ` Frank Doepper
@ 2019-12-25 13:41 ` Sergey Matveev
2019-12-25 14:46 ` Frank Doepper
2 siblings, 1 reply; 15+ messages in thread
From: Sergey Matveev @ 2019-12-25 13:41 UTC (permalink / raw)
To: nncp-devel
[-- Attachment #1: Type: text/plain, Size: 548 bytes --]
*** Shawn K. Quinn [2019-12-22 14:17]:
>And now connections fail 10 seconds in every time:
I made 5.3.1 release where I have found that piped connection did not
process deadlines correctly (addresses like "|ssh ..."). I still could
not get errors related to ordinary direct TCP connections (between
nncp-call and nncp-daemon) (tried between FreeBSD boxes and
FreeBSD<->Debian one). Possibly that releases fixes your issue too.
--
Sergey Matveev (http://www.stargrave.org/)
OpenPGP: CF60 E89A 5923 1E76 E263 6422 AE1A 8109 E498 57EF
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [nncp-devel] EOF while decoding 8 bytes / message authentication failed
2019-12-25 13:41 ` Sergey Matveev
@ 2019-12-25 14:46 ` Frank Doepper
2019-12-28 12:05 ` Sergey Matveev
0 siblings, 1 reply; 15+ messages in thread
From: Frank Doepper @ 2019-12-25 14:46 UTC (permalink / raw)
To: Sergey Matveev; +Cc: nncp-devel
Hi Sergey,
> >And now connections fail 10 seconds in every time:
>
> I made 5.3.1 release where I have found that piped connection did not
> process deadlines correctly (addresses like "|ssh ..."). I still could
> not get errors related to ordinary direct TCP connections (between
> nncp-call and nncp-daemon) (tried between FreeBSD boxes and
> FreeBSD<->Debian one). Possibly that releases fixes your issue too.
Thank you! But unfortunately our bug is not yet fixed.
I must note that the bug only triggers when there is data to send
actually:
$ nncp-call -txrate 1 android
2019-12-25T14:37:44Z We have got for android: 1 packets, 13 MiB
2019-12-25T14:37:44Z Connection to android
2019-12-25T14:37:55Z Tx GKA..FQA 701 KiB/13 MiB 5% (63 KiB/sec)
E 2019-12-25T14:37:56.672727955Z [sp-xmit err="write tcp 192.168.2.103:52432->192.168.2.102:5400: use of closed network connection" nice="255" node="NUU..RDQ"]
2019-12-25T14:37:56Z Finished call with android: 32 KiB received (32 KiB/sec), 734 KiB transferred (67 KiB/sec)
Best regards,
Frank
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2019-12-28 17:55 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-13 9:19 [nncp-devel] EOF while decoding 8 bytes / message authentication failed Frank Doepper
2019-12-13 16:20 ` Sergey Matveev
2019-12-17 15:26 ` Frank Doepper
2019-12-20 9:01 ` Sergey Matveev
2019-12-20 11:32 ` Frank Doepper
2019-12-20 13:51 ` Sergey Matveev
2019-12-20 14:04 ` Frank Doepper
2019-12-22 18:30 ` Sergey Matveev
2019-12-22 20:17 ` Shawn K. Quinn
2019-12-22 20:42 ` Sergey Matveev
2019-12-24 11:59 ` Frank Doepper
2019-12-25 13:41 ` Sergey Matveev
2019-12-25 14:46 ` Frank Doepper
2019-12-28 12:05 ` Sergey Matveev
2019-12-28 17:51 ` Frank Doepper